Skip to content
Snippets Groups Projects

F fix compare entities branch2

Merged Alexander Schlemmer requested to merge f-fix-compare-entities-branch2 into dev
1 unresolved thread

Summary

This is a fix for #81 (closed) .

Focus

I added a statement analogous to existing statements for datatype and importance that compares the values of the entities.

Test Environment

I added a unit test in test_apiutils.py.

Issue #81 (closed) contains a script for testing it manually.

Check List for the Author

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Add type hints in created/changed code
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?
Edited by Henrik tom Wörden

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
623 639 newdiff["properties"][prop.name]["datatype"] = \
624 640 matching[0].datatype
625 641
642 if ((prop.value is not None and
  • added 1 commit

    • a9de885e - DOC: corrected mistake in changelog

    Compare with previous version

  • Alexander Schlemmer changed target branch from main to dev

    changed target branch from main to dev

  • mentioned in issue #81 (closed)

  • added 1 commit

    Compare with previous version

  • Alexander Schlemmer marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • added 1 commit

    Compare with previous version

  • Henrik tom Wörden marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Henrik tom Wörden marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Henrik tom Wörden marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Henrik tom Wörden marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Henrik tom Wörden marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

    marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

  • Henrik tom Wörden enabled an automatic merge when the pipeline for ca71283a succeeds

    enabled an automatic merge when the pipeline for ca71283a succeeds

  • mentioned in commit 945a1f35

  • Please register or sign in to reply
    Loading