F fix compare entities branch2
1 unresolved thread
1 unresolved thread
Summary
This is a fix for #81 (closed) .
Focus
I added a statement analogous to existing statements for datatype and importance that compares the values of the entities.
Test Environment
I added a unit test in test_apiutils.py.
Issue #81 (closed) contains a script for testing it manually.
Check List for the Author
-
All automated tests pass -
Reference related Issues -
Up-to-date CHANGELOG.md -
Add type hints in created/changed code -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there spezifications? Are they satisfied?
Edited by Henrik tom Wörden
Merge request reports
Activity
requested review from @henrik
assigned to @salexan
623 639 newdiff["properties"][prop.name]["datatype"] = \ 624 640 matching[0].datatype 625 641 642 if ((prop.value is not None and changed this line in version 5 of the diff
mentioned in issue #81 (closed)
enabled an automatic merge when the pipeline for ca71283a succeeds
mentioned in commit 945a1f35
Please register or sign in to reply