F is reference role

Summary

The role check in this particular function had to be removed because it is not necessary and could lead to unwanted errors in this function. See #72 (closed)

Focus

models.py

Test Environment

Test the integrationtests from the advanced-user-tools.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related Issues
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosdb/common/models.py

@@ -1551,6 +1551,11 @@ class Property(Entity):
 
                 if server_retrieval:
                     tmp_prop = deepcopy(self)
+                    """
+                    remove role to avoid unnessecary ValueError while
+                    retrieving the Entity.
+                    """
+                    tmp_prop.role = None
                     tmp_prop.retrieve()
 
                     return tmp_prop.is_reference()