Skip to content
Snippets Groups Projects

FEAT: `resolve_references` parameter

Merged FEAT: `resolve_references` parameter
f-enh-143-xlsx-export-with-props into dev
1 unresolved thread
Merged Daniel Hornung requested to merge f-enh-143-xlsx-export-with-props into dev
1 unresolved thread

Summary

Adding new parameter and simplifying code. Useful for batch conversion of many Records. See caosdb-advanced-user-tools#143 (closed)

Focus

Is this sufficiently backwards compatible?

Test Environment

Run the new integration test in the corresponding feature branch.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung
    Daniel Hornung @daniel started a thread on the diff
    • src/linkahead/high_level_api.py
    986 988 """
    987 989 if isinstance(entity, db.Container):
    988 990 # Create a list of objects:
    989 return [convert_to_python_object(i, references, visited) for i in entity]
    991 return [convert_to_python_object(ent, references=references, visited=visited,
    992 resolve_references=resolve_references) for ent in entity]
    990 993
    991 994 # TODO: recursion problems?
    992 return _single_convert_to_python_object(
    995 converted = _single_convert_to_python_object(
    993 996 high_level_type_for_standard_type(entity)(),
    994 997 entity,
    995 998 references,
    996 999 visited)
    1000 if resolve_references:
    1001 converted.resolve_references(True, references)
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung left review comments

    left review comments

  • Henrik tom Wörden mentioned in commit b60a4dc5

    mentioned in commit b60a4dc5

  • Henrik tom Wörden merged

    merged

    • Please register or sign in to reply