Skip to content
Snippets Groups Projects

Fix pylint warnings

Merged Fix pylint warnings
f-240-fix-pylint-warnings into dev
1 unresolved thread
Merged I. Nüske requested to merge f-240-fix-pylint-warnings into dev
1 unresolved thread

Summary

Addresses #240 (closed)
Four pylint warnings are now ignored, one probable bug fixed

Focus

Are any of the warnings now marked as false positive in fact true positives?

Test Environment

Does the pylint job in the pipeline succeed?

Check List for the Author

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • Annotations in code (Gitlab comments)

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?
Edited by Florian Spreckelsen

Merge request reports

Pipeline #62390 passed

Stage: code_style
Stage: linting
Stage: test
Stage: deploy
Pipeline: LinkAhead

#62392

    Pipeline passed for d3b90636 on f-240-fix-pylint-warnings

    Approval is optional

    Merged by Florian SpreckelsenFlorian Spreckelsen 1 week ago (Apr 1, 2025 1:11pm UTC)

    Merge details

    • Changes merged into with 1faa79e7.
    • Deleted the source branch.

    Pipeline #62623 failed

    Stage: setup
    Stage: code_style
    Stage: linting
    Stage: test
    Stage: deploy

    Pipeline failed for 1faa79e7 on dev

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • I. Nüske added 1 commit

    added 1 commit

    • d3b90636 - FIX: Revert accidental rename

    Compare with previous version

  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske
    I. Nüske @i.nueske started a thread on the diff
    • src/linkahead/connection/connection.py
    777 778 if self._authenticator._credentials_provider is None:
    778 779 raise ValueError(
    779 780 "No credentials provider set. Please call configure_connection() first.")
    780 781 return self._authenticator._credentials_provider.username
    • Comment on lines 765 to 780
      I. Nüske
      I. Nüske @i.nueske ·
      Author Developer

      This is the function where CredentialsAuthenticator is used, in Line 777: assert isinstance(self._authenticator, CredentialsAuthenticator)

    • Please register or sign in to reply
  • I. Nüske marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • I. Nüske marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • I. Nüske marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • I. Nüske marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen mentioned in commit 1faa79e7

    mentioned in commit 1faa79e7

  • Florian Spreckelsen merged

    merged

    • Please register or sign in to reply