MAINT: rename filter to filter_by_identity
Summary
Rename the filter function to prevent confusion that it does not behave like standard filter functions
Test Environment
pipelines
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Alexander Schlemmer
Merge request reports
Activity
assigned to @henrik
added 6 commits
-
dbeef18c...75531f1c - 4 commits from branch
dev
- 334c5113 - Merge branch 'dev' into f-rename-filter
- 8dc09b2e - MAINT: rename the filter function of Container
-
dbeef18c...75531f1c - 4 commits from branch
added 1 commit
- e0554c5e - MAINT: rename the filter function of Container
mentioned in issue #218 (closed)
- Resolved by Henrik tom Wörden
- Resolved by Henrik tom Wörden
requested review from @salexan
added 20 commits
-
71f51dd3...600505d1 - 19 commits from branch
dev
- 6e6c050f - Merge branch 'dev' into 'f-rename-filter'
-
71f51dd3...600505d1 - 19 commits from branch
Please register or sign in to reply