Skip to content
Snippets Groups Projects

MAINT: rename filter to filter_by_identity

Merged Henrik tom Wörden requested to merge f-rename-filter into dev

Summary

Rename the filter function to prevent confusion that it does not behave like standard filter functions

Test Environment

pipelines

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Pipeline #59871 passed with warnings

Pipeline: LinkAhead

#59872

    Pipeline passed with warnings for 6e6c050f on f-rename-filter

    Approval is optional

    Set by to be merged automatically when the pipeline succeeds

    Ready to merge by members who can write to the target branch.

    Merge details

    • 47 commits and 1 merge commit will be added to dev.
    • Source branch will be deleted.
    • Auto-merge enabled

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • added 1 commit

    • 71f51dd3 - TST: add unittest for deprecation warning

    Compare with previous version

  • Henrik tom Wörden resolved all threads

    resolved all threads

  • Alexander Schlemmer changed the description

    changed the description

  • requested review from @salexan

  • added 20 commits

    Compare with previous version

  • Alexander Schlemmer marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Alexander Schlemmer marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Alexander Schlemmer marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading