Skip to content
Snippets Groups Projects

F convenient admin

Merged
Alexander Schlemmerrequested to merge
f-convenient-admin into dev
1 open thread

Summary

This MR adds a few convenience features to caosdb_admin:

  • Allow activating users directly after creation.
  • Allow setting a password on the command line.

This is important for allowing automated scripts to batch generate passwords and users.

Focus

I updated the documentation in argparse and hope that it matches the programming logic exactly. Please check.

Test Environment

Just check out this branch and create a user in an instance of your choice, e.g. using: python3 -m caosdb.utils.caosdb_admin create_user username email password

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
331 344
332 345 subparser = subparsers.add_parser(
333 346 "set_user_password",
334 help="Set a new password for a user. The password is not to be given on the command line for security reasons. You will be prompted for the password.")
347 help="Set a new password for a user. You will be prompted for the password if PASSWORD is not given.")
  • Please have a closer look at the logic: I think in this new implementation, giving a password is required. If it's not given on the command line, the program will ask for it. Is this the desired behaviour?

  • Please register or sign in to reply
  • Alexander Schlemmer marked the checklist item Reference related Issues as completed

    marked the checklist item Reference related Issues as completed

  • Alexander Schlemmer marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • added 1 commit

    Compare with previous version

  • Alexander Schlemmer marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Alexander Schlemmer assigned to @florian and unassigned @salexan

    assigned to @florian and unassigned @salexan

  • mentioned in issue #58 (closed)

  • Please register or sign in to reply
    Loading