For #215 (closed) (https://gitlab.com/linkahead/linkahead-pylib/-/issues/87). Fixes an issue whereby the HTTPServerError
class would have too strong assumptions regarding the validity and the contents of the XML response. This would cause problems especially when encountering proxy or other network timeouts.
This doesn't extend any error handling, it simply ensures that the error can be created correctly.
New unit tests should be sufficient. You can also provoke the original bug by starting LinkAhead with envoy_enabled: true
and envoy_rout_timeout
set to something very low, e.g., 5 s. Then, I could provoke the original bug by inserting a container with 5000 entities.
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.