Skip to content
Snippets Groups Projects

Prevent auth_token from being overwritten with None

Merged Prevent auth_token from being overwritten with None
f-fix-login-failed-on-long-request into dev
All threads resolved!
Merged I. Nüske requested to merge f-fix-login-failed-on-long-request into dev
All threads resolved!

Summary

Addresses https://gitlab.indiscale.com/caosdb/customers/f-fit/management/-/issues/82 / https://gitlab.com/linkahead/linkahead-pylib/-/issues/103
The auth_token is no longer overwritten with None in authentication/interface/on_response(), preventing the AuthTokenAuthenticator from becoming invalid when a request does not provide a new token in the "Set-Cookie" header.
Test MR is here.

Test Environment

Manual Testing

Check List for the Author

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • Annotations in code (Gitlab comments)

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?
Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I. Nüske
  • I. Nüske
  • I. Nüske requested review from @florian

    requested review from @florian

  • Florian Spreckelsen added 20 commits

    added 20 commits

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen mentioned in commit 6a9d6561

    mentioned in commit 6a9d6561

  • Florian Spreckelsen merged

    merged

    • Please register or sign in to reply