Skip to content
Snippets Groups Projects

F list filter

Merged Henrik tom Wörden requested to merge f-list-filter into f-review-lists-and-compare
2 files
+ 37
10
Compare changes
  • Side-by-side
  • Inline

Files

+ 4
0
@@ -251,12 +251,16 @@ def compare_entities(entity0: Optional[Entity] = None,
@@ -251,12 +251,16 @@ def compare_entities(entity0: Optional[Entity] = None,
# - Should there be a more detailed comparison of parents without id?
# - Should there be a more detailed comparison of parents without id?
# - Revisit filter - do we care about RecordType when matching?
# - Revisit filter - do we care about RecordType when matching?
# How to treat None?
# How to treat None?
 
# - Should matching of parents also take the recordtype into account
 
# for parents that have a name but no id?
# Suggestions for enhancements:
# Suggestions for enhancements:
# - For the comparison of entities in value and properties, consider
# - For the comparison of entities in value and properties, consider
# keeping a list of traversed entities, not only look at first layer
# keeping a list of traversed entities, not only look at first layer
# - Make the empty_diff functionality faster by adding a parameter to
# - Make the empty_diff functionality faster by adding a parameter to
# this function so that it returns after the first found difference?
# this function so that it returns after the first found difference?
# - Add parameter to restrict diff to some characteristics
# - Add parameter to restrict diff to some characteristics
 
# - Implement comparison of date where one is a string and the other is
 
# datetime
if entity0 is None and old_entity is None:
if entity0 is None and old_entity is None:
raise ValueError("Please provide the first entity as first argument (`entity0`)")
raise ValueError("Please provide the first entity as first argument (`entity0`)")
if entity1 is None and new_entity is None:
if entity1 is None and new_entity is None:
Loading