F entity role

Summary

Fixes unintuitive behavior of "Entity.role" after a retrieval.

(As per the bug report in the CaosDB matrix chat)

1. When an entity is retrieved with a class (i.e. a subtype of Entity) which does not match the entity role, an exception is being raised.
2. When an entity is retrieved using the Entity class, the correct role is set and available via Entity.role

Focus

The only real changes are in models.py. See the annotations for more info.

Everything else is just new tests covering the changes.

Test Environment

• No manual testing necessary.
• See unit tests in this MR
• See integration tests in caosdb-pyinttest!19 (merged)

Check List for the Author

• All automated tests pass
• Reference related Issues
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there spezifications? Are they satisfied?
• remove xfail from pyint test (line 587; test_misc.py): @mark.xfail(reason="Waits for MR https://gitlab.indiscale.com/caosdb/src/caosdb-pylib/-/merge_requests/15")

For further good practices have a look at our review guidelines.

src/caosdb/common/models.py

@@ -831,7 +831,6 @@ class Entity(object):
         """
 
         if xml is None:
-            xml = etree.Element("Entity")
             # use role as xml tag name, fall-back to "Entity"
             elem_tag = "Entity" if self.role is None else self.role
             xml = etree.Element(elem_tag)
@@ -1276,7+1275,7 @@
         self.datatype = None
         self.messages = _Messages()
         self.properties = None
         self.parents = None
         self.path = None
         self.file = None
         self._checksum = None