Skip to content

F fix datetime value

Florian Spreckelsen requested to merge f-fix-datetime-value into dev

Summary

For #202 (closed) (https://gitlab.com/linkahead/linkahead-pylib/-/issues/128). Fixes _parse_value so that datetime.date and datetime.datetime values can be assigned. Note that the problem was always only on the client-side, cf. https://gitlab.com/linkahead/linkahead-pylib/-/issues/128#adding-vs-updating.

Focus

Simply allow datetime.date(time) values and treat them as they would have been treated in case of datatype=None.

Test Environment

New unit test should be sufficient. Feel free to run the extended example with a local linkahead, though.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports