Skip to content

FIX: Fix unwanted subproperties

Florian Spreckelsen requested to merge f-fix-120-subproperties into dev

Summary

Fix for #196 (closed). The subproperties were set because one erroneous inheritance ALL instead of FIX in the end.

Focus

Properties should have the default (always?) inheritance FIX. Everything else would imply that the properties of the entity being added to the _Properties list inherit their properties depending on the importance. I don't see any reason why their should be an inheritance here at all, but that's beyond the scope of this MR.

Test Environment

New int test from https://gitlab.com/linkahead/linkahead-pyinttest/-/commit/15b2e3f153d733b5a94fd3bc0fbc9a3f0b6f99b5

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports