ENH: Allow kwargs for Entity.update in Entity.update_acl
requested to merge f-update-acl into f-192-add-type-hints-for-smaller-modules-in-common-and-connection
Summary
For https://gitlab.indiscale.com/caosdb/customers/geomar/management/-/issues/255, implements https://gitlab.com/linkahead/linkahead-pylib/-/issues/112. Simply allow to pass through **kwargs
to the underlying Entity.update()
call, thus allowing a unique=False
.
Focus
**kwargs
are just passed through. Also look at the new docstring.
Test Environment
Integration tests in caosdb-pyinttest!77.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Daniel Hornung