Add and fix more type hints

Summary

Related to #192 (closed)

Adding more type hints to smaller modules than models.py

Focus

Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/linkahead/common/models.py

@@ -183,6 +183,7 @@ class Entity:
         Special attributes, as defined by the global variable SPECIAL_ATTRIBUTES and additionaly
         the "value" are copied using setattr.
         """
+        new: Union[File, Property, RecordType, Record, Entity]
         if self.role == "File":
             new = File()
         elif self.role == "Property":
@@ -462,6 +463,8 @@ class Entity:
 
     def revoke_denial(self, realm=None, username=None,
                       role=None, permission=None, priority=False):
+        if self.acl is None:
+            raise EntityHasNoAclError("This entity does not have an ACL (yet).")
         self.acl.revoke_denial(
             realm=realm,
             username=username,
@@ -471,6 +474,8 @@ class Entity:
 
     def revoke_grant(self, realm=None, username=None,
                      role=None, permission=None, priority=False):
+        if self.acl is None:
+            raise EntityHasNoAclError("This entity does not have an ACL (yet).")
         self.acl.revoke_grant(
             realm=realm,
             username=username,
@@ -1464,6 +1469,8 @@ out: List[Entity]
                 raise TransactionError(ae)
         else:
             e = Container().retrieve(query=self.id, sync=False)[0]
+        if self.acl is None:
+            raise EntityHasNoAclError("This entity does not have an ACL yet. Please set one first.")
         e.acl = ACL(self.acl.to_xml())
         e.update()
 
@@ -2443,6 +2450,7 @@ class _Properties(list):
         return self
 
     def to_xml(self, add_to_element: etree._Element, add_properties: INHERITANCE):
+        p: Property
         for p in self:
             importance = self._importance.get(p)
 
@@ -3581,7 +3589,8 @@ class Container(list):
                         if is_list_datatype(prop_dt):
                             ref_name = get_list_datatype(prop_dt)
                             try:
-                                is_being_referenced.add(container.get_entity_by_name(ref_name).id)  # type: ignore
+                                is_being_referenced.add(
+                                    container.get_entity_by_name(ref_name).id)  # type: ignore
                             except KeyError:
                                 pass
                         elif isinstance(prop_dt, str):
@@ -4759,7 +4768,8 @@ class Query():
             next_page = self._query_request(query_dict)
             etag = next_page.query.etag
             if etag is not None and etag != self.etag:
-                raise PagingConsistencyError("The database state changed while retrieving the pages")
+                raise PagingConsistencyError(
+                    "The database state changed while retrieving the pages")
             yield next_page
             index += page_length