Skip to content

F merge id with resolved entity

Florian Spreckelsen requested to merge f-merge-id-with-resolved-entity into dev

Summary

One half of the fix for caosdb-crawler#113 (closed). Introduces a merge_id_with_resolved_entity parameter to the apiutils.merge_entities function, that allows to identify an id value of a reference property with an entity that has this id.

Focus

Check whether you can find cases that the new unit test doesn't cover.

Test Environment

Unit test should be sufficient, but you can also run the new int test from caosdb-crawler!141 (merged) and verify that this enhancement resolves the bug.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports