TEST: xfail for issue 111

Summary

For #181 (closed).

Focus

Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

setup.py

@@ -97,6 +97,7 @@ def get_version_info():
     FULLVERSION = VERSION
 
     # Magic which is only really needed in the pipelines. Therefore: a lot of dark pipeline magic.
+    GIT_REVISION = "Unknown"
     if os.path.exists('.git'):
         GIT_REVISION = git_version()
     elif os.path.exists('linkahead_pylib_commit'):
@@ -105,14 +106,12 @@ def get_version_info():
     elif os.path.exists('src/linkahead/version.py'):
         # must be a source distribution, use existing version file
         with open('src/linkahead/version.py') as fi:
+            rev_pattern = re.compile(r"^git_revision = '(?P<rev>.*)'$")
             for line in fi.readlines():
-                match = re.match(r"^git_revision = (?P<rev>.*)$", line)
-
+                match = rev_pattern.match(line)
                 if match is not None:
                     GIT_REVISION = match.group('rev')
-
-    else:
-        GIT_REVISION = "Unknown"
+                    break
 
     if not ISRELEASED:
         FULLVERSION += '.dev0+' + GIT_REVISION[:7]