LinkAhead rename lvl 0
-
Review changes -
Open in Workspace
-
-
Download -
Patches
-
Plain diff
Summary
LinkAhead Rename; First step with no action required for users.
Focus
Due to the renaming the 'Changes' tab in this MRis basically useless. Please have a look at the changes in !113 (closed) instead. The branch of this MR is created from the other one by renaming the module and by creating a thin wrapper with the old name.
The main changes are:
- renaming in docs
- renamed CaosDBException; deprecated old version exists; catching CaosDBException also catches the new one
- renamed CaosDBConnectionError; deprecated old version exists; catching CaosDBException also catches the new one
- old ini paths are deprecated, but still work. The new inis however take precedence over old ones
-
caosdb_admin
->linkahead_admin
; both can be used now. - changed imports to relative or to
linkahead
Test Environment
- check that the exception test properly and sufficiently tests that the exceptions are properly deprecated
- this pipeline
- test manually that you can use both admins scipts and that they are both in the path. The old one creates a warning.
- manually test the deprecation of the old ini file names and make sure that the content is still considered
- integration test [dev] against this branch: caosdb-pyinttest!66 (and check that we did test against the correct pylib version)
- check that there are no unexpected changes necessary in caosdb-pyinttest!66
Merge Procedure
-
review changes in !113 (closed) -
make sure above named tests pass -
merge !112 (merged) -
delete !113 (closed)
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen
Merge request reports
Compare and
- version 27f02d6491
- version 26f02d6491
- version 25a890293a
- version 24959795bd
- version 2371ce3cff
- version 22d1355211
- version 21d1355211
- version 20001dd66a
- version 19001dd66a
- version 185b11320d
- version 17dbba85ae
- version 16dbba85ae
- version 15dbba85ae
- version 14c0f68ae9
- version 1338a8e4a8
- version 1283a0607e
- version 11041a948d
- version 100cdf933d
- version 9942a6b90
- version 806eb0040
- version 734c67bb3
- version 6a2e9d18a
- version 5fe7b4cda
- version 47aae0ac0
- version 38f0601d5
- version 2eaba7fe8
- version 13140daa8
- dev (base)
- latest version8de757e616 commits,
- version 27f02d649115 commits,
- version 26f02d64916 commits,
- version 25a890293a4 commits,
- version 24959795bd2 commits,
- version 2371ce3cff2 commits,
- version 22d13552113 commits,
- version 21d13552112 commits,
- version 20001dd66a5 commits,
- version 19001dd66a2 commits,
- version 185b11320d2 commits,
- version 17dbba85ae5 commits,
- version 16dbba85ae5 commits,
- version 15dbba85ae7 commits,
- version 14c0f68ae94 commits,
- version 1338a8e4a810 commits,
- version 1283a0607e9 commits,
- version 11041a948d8 commits,
- version 100cdf933d7 commits,
- version 9942a6b906 commits,
- version 806eb00405 commits,
- version 734c67bb35 commits,
- version 6a2e9d18a3 commits,
- version 5fe7b4cda1 commit,
- version 47aae0ac04 commits,
- version 38f0601d53 commits,
- version 2eaba7fe82 commits,
- version 13140daa81 commit,
Compare changes
- Side-by-side
- Inline
Files
120Loading