1 unresolved thread
1 unresolved thread
Summary
Test for https://gitlab.com/linkahead/linkahead-pylib/-/issues/127
Code MR is here.
Check List for the Author
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
Annotations in code (Gitlab comments)
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
Edited by Alexander Schlemmer
Merge request reports
Activity
assigned to @i.nueske
changed title from TST: Added test for https://gitlab.com/linkahead/linkahead-pylib/-/issues/127{- and updated changelog-} to Add test for https://gitlab.com/linkahead/linkahead-pylib/-/issues/127
added 1 commit
- ddaddb1c - TST: test_gitlab_com_127 does not depend on test profile anymore
mentioned in merge request caosdb-pylib!167 (merged)
added 1 commit
- 60fb5063 - TST: Fix timeout reset in test_gitlab_com_127
requested review from @salexan
205 connect/read timeouts and timeout None. 206 207 See https://gitlab.com/linkahead/linkahead-pylib/-/issues/127 and 208 https://gitlab.indiscale.com/caosdb/customers/f-fit/management/-/issues/93 209 """ 210 # Setup paths and save previous timeout 211 base_dir = Path(__file__).parent.parent 212 temp_pylinkahead_path = base_dir/'.pyla-temp-test.ini' 213 temp_pylinkahead_path.unlink(True) 214 prev_timeout = None 215 if db.get_config().has_option('Connection', 'timeout'): 216 prev_timeout = db.get_config().get('Connection', 'timeout') 217 218 # Parse various timeout strings and check successful connect 219 valid_timeout_strings = ["timeout = None", "timeout=null", 220 "timeout = (4, 40)", "timeout=(4,4)"] changed this line in version 4 of the diff
added 5 commits
-
60fb5063...7c8a480f - 3 commits from branch
dev
- a3955362 - Merge branch 'refs/heads/dev' into f-enh-fit-93-pylinkahead-separate-timeouts
- 11709281 - TST: Additional valid test strings for test_gitlab_com_127
-
60fb5063...7c8a480f - 3 commits from branch
reset approvals from @salexan by pushing to the branch
mentioned in commit d362a52a
Please register or sign in to reply