Skip to content
Snippets Groups Projects

FIX: Pandas deprecation warning.

Merged Daniel Hornung requested to merge f-fix-pandas-deprecation into dev
1 unresolved thread

Summary

More relaxed behavior towards stderr output of server-side scripts. #21 (closed)

Focus

Nothing special.

Test Environment

Look at the pipelines. Or rebuild your LinkAhead, then run

pytest tests/test_server_side_scripting.py (Don't worry about unrelated failure if you don't have your LinkAhead instance configured properly for integration tests.)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues #21 (closed)
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
70 70 d.delete()
71 71
72 72
73 def assert_stderr(stderr) -> None:
  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Daniel Hornung added 2 commits

    added 2 commits

    Compare with previous version

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung added 1 commit

    added 1 commit

    • 6a95bc13 - DOC: Better server-side scripting documentation.

    Compare with previous version

  • Daniel Hornung requested review from @florian

    requested review from @florian

  • Daniel Hornung mentioned in merge request !75 (merged)

    mentioned in merge request !75 (merged)

  • added 4 commits

    Compare with previous version

  • Florian Spreckelsen approved this merge request

    approved this merge request

  • mentioned in commit 6b757c01

  • Please register or sign in to reply
    Loading