TST: Add xfailing tests for the permissions for referenced entities
Summary
Tests for https://gitlab.indiscale.com/caosdb/customers/geomar/management/-/issues/197
Focus
Two new tests that confirm the bug with insufficient permission checks.
- One for filters (cf https://demo.indiscale.com/Entity/?P=0L10&query=FIND%20Guitar%20WITH%20MusicalAnalysis%3D%22ThisMusa%22)
- One for selectors (cf https://demo.indiscale.com/Entity/?query=SELECT%20name%2C%20MusicalAnalysis.name%20FROM%20365)
Check whether you think they are sufficient or whether you can come up with more corner cases.
Test Environment
In principle, pipelines should be sufficient, but you can of course remove the xfails and run the new tests locally to verify that they fail in the correct spots.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.