Skip to content
Snippets Groups Projects

ENH: Test for issue caosdb-server#192 (automatic name for mass-imported File entities)

Merged ENH: Test for issue caosdb-server#192 (automatic name for mass-imported File entities)
f-no-automatic-file-naming into dev
2 unresolved threads
Merged Daniel Hornung requested to merge f-no-automatic-file-naming into dev
2 unresolved threads

Summary

The changes now check that there is NO name for the InsertFilesInDir files any more.

Focus

Did I miss anything? Is a None name correct?

Test Environment

  • Set up the integration tests as usual, also make sure that the test_files.test_insert_files_in_dir.{local,server} variables in pycaosdb.ini are usable.
  • pytest tests/test_file.py

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues caosdb/customers/umg/management#68
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
tests/test_file.py
536 536 assert_is_not_none(c.messages["Info", 0])
537 537 assert_equal(c.messages["Info", 0][0],
538 538 "Files count in linked_subfolder/: 1")
539 assert_equal(c[0].name, "test2.dat")
539 assert c[0].name is None
  • Daniel Hornung
    Daniel Hornung @daniel started a thread on the diff
    • CITATION.cff 0 → 100644
    1 cff-version: 1.2.0
  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Daniel Hornung mentioned in merge request caosdb-server!85 (merged)

    mentioned in merge request caosdb-server!85 (merged)

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung requested review from @timm

    requested review from @timm

  • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Timm Fitschen marked the checklist item I understand the intent of this MR as incomplete

    marked the checklist item I understand the intent of this MR as incomplete

  • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Timm Fitschen marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Timm Fitschen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Timm Fitschen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Timm Fitschen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Timm Fitschen approved this merge request

    approved this merge request

  • Timm Fitschen merged

    merged

  • Timm Fitschen mentioned in commit fdb46c54

    mentioned in commit fdb46c54

    • Please register or sign in to reply