Skip to content

ENH: Test for issue caosdb-server#192 (automatic name for mass-imported File entities)

Daniel Hornung requested to merge f-no-automatic-file-naming into dev

Summary

The changes now check that there is NO name for the InsertFilesInDir files any more.

Focus

Did I miss anything? Is a None name correct?

Test Environment

  • Set up the integration tests as usual, also make sure that the test_files.test_insert_files_in_dir.{local,server} variables in pycaosdb.ini are usable.
  • pytest tests/test_file.py

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues caosdb/customers/umg/management#68
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Loading