Get parents recursively

Summary

Re-enabled tests and added new test for:

Entity.get_parents_recursively() does not work for unretrieved parents caosdb-pylib#90

Focus

Does this cover the reported issue?

Test Environment

pytest-3 -k recurs or pytest-3 tests/test_recursive_parents.py

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

tests/test_recursive_parents.py

@@ -48,7 +48,26 @@ def teardown_function(function):
     setup_module()
 
 
-@pytest.mark.xfail(reason="To be fixed in server and/or pylib")
+def test_get_parents_recursively():
+    """Test for https://gitlab.com/caosdb/caosdb-pylib/-/issues/90
+
+> Entity.get_parents_recursively() does not work unless the full ancestry has been retrieved from
+> the server.
+"""
+    # Setup
+    rt_A = db.RecordType(name="TestA")
+    rt_B = db.RecordType(name="TestB").add_parent(rt_A)
+    rt_C = db.RecordType(name="TestC").add_parent(rt_B)
+    db.Container().extend([rt_A, rt_B, rt_C]).insert()
+
+    # Retrieve only C
+    retrieved_C = db.RecordType(name="TestC").retrieve()
+    parents = retrieved_C.get_parents_recursively(retrieve=True)
+    assert len(parents) == 2
+    assert "TestB" in [p.name for p in parents]
+    assert "TestA" in [p.name for p in parents]
+
+
 def test_recursive_parents():
     # inheritance structure:
     #    A
@@ -66,29 +85,31 @@ def test_recursive_parents():
 
     parents = C.get_parents_recursively()
     assert len(parents) == 3
-    assert A in parents
-    assert B in parents
-    assert B2 in parents
+    parent_identifiers = [(all_p.id, all_p.name) for all_p in parents]
+    assert (A.id, A.name) in parent_identifiers
+    assert (B.id, B.name) in parent_identifiers
+    assert (B2.id, B2.name) in parent_identifiers
 
     parents = c.get_parents_recursively()
     assert len(parents) == 4
-    assert A in parents
-    assert B in parents
-    assert B2 in parents
-    assert C in parents
+    parent_identifiers = [(all_p.id, all_p.name) for all_p in parents]
+    assert (A.id, A.name) in parent_identifiers
+    assert (B.id, B.name) in parent_identifiers
+    assert (B2.id, B2.name) in parent_identifiers
+    assert (C.id, C.name) in parent_identifiers
 
     # Now do a time travel and great-grand-parentize yourself...
     A.add_parent(C).update()
 
     parents = C.get_parents_recursively()
     assert len(parents) == 4
-    assert A in parents
-    assert B in parents
-    assert B2 in parents
-    assert C in parents
+    parent_identifiers = [(all_p.id, all_p.name) for all_p in parents]
+    assert (A.id, A.name) in parent_identifiers
+    assert (B.id, B.name) in parent_identifiers
+    assert (B2.id, B2.name) in parent_identifiers
+    assert (C.id, C.name) in parent_identifiers
 
 
-@pytest.mark.xfail(reason="To be fixed in server and/or pylib")
 def test_entity_has_parent():
     # inheritance structure:
     #    A
@@ -137,8 +158,8 @@ def test_entity_has_parent():
     assert not c.has_parent(fake_C_id, check_name=False,
                             check_id=True)
 
-    fake_B_name_id = RecordType(name="TestTypeB", id=B.id)
-    fake_C_name_id = RecordType(name="not C", id=C.id * 5)
+    fake_B_name_id = db.RecordType(name="TestTypeB", id=B.id)
+    fake_C_name_id = db.RecordType(name="not C", id=C.id * 5)
 
     assert c.has_parent(fake_B_name_id, check_name=True,
                         check_id=True)