TST: un-xfail tests for caosdb-server#130

Summary

Tests for caosdb-server!59 (merged)

Focus

Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

tests/test_issues_server.py

@@ -472,7 +472,6 @@ def test_issue_183():
                                       "(yyyy-mm-dd'T'hh:mm:ss[.fffffffff][TimeZone]).")
 
 
-@pytest.mark.xfail(reason="fix https://gitlab.com/caosdb/caosdb-server/-/issues/130")
 def test_issue_130():
     """Test select queries where names contain spaces
 
@@ -506,7 +505,7 @@ def test_issue_130():
 
     query = "SELECT 'TestWrapper' FROM RECORD TestRT_B"
     row = db.execute_query(query).get_property_values(("TestWrapper", "id"))
-    assert row == [(r1.id,)]  # FAILS
+    assert row == [(p1.id,)]
 
     query = "SELECT TestWrapper FROM RECORD TestRT_B"
     row = db.execute_query(query).get_property_values(("TestWrapper", "name"))
@@ -517,12 +516,12 @@ def test_issue_130():
     assert row == [("ReferencedRecord",)]
 
     query = "SELECT 'TestWrapper.name' FROM RECORD TestRT_B"
-    row = db.execute_query(query).get_property_values(("TestWrapper", "name"))
-    assert row == [("ReferencedRecord",)]  # FAILS
+    rec = db.execute_query(query, unique=True)
+    assert len(rec.properties) == 0
 
     query = "SELECT 'TestWrapper'.name FROM RECORD TestRT_B"
     row = db.execute_query(query).get_property_values(("TestWrapper", "name"))
-    assert row == [("ReferencedRecord",)]  # FAILS
+    assert row == [("ReferencedRecord",)]
 
     query = "SELECT TestWrapper With Spaces FROM RECORD TestRT_B"
     row = db.execute_query(query).get_property_values(
@@ -542,23 +541,17 @@ def test_issue_130():
     query = 'SELECT "TestWrapper With Spaces" FROM RECORD TestRT_B'
     row = db.execute_query(query).get_property_values(
         ("TestWrapper With Spaces", "name"))
-    assert row == [("ReferencedRecord",)]  # FAILS
+    assert row == [("TestWrapper With Spaces",)]
 
     query = 'SELECT TestWrapper With Spaces.name FROM RECORD TestRT_B'
     row = db.execute_query(query).get_property_values(
         ("TestWrapper With Spaces", "name"))
-    # Works!!! This is about the quotation marks
     assert row == [("ReferencedRecord",)]
 
-    query = 'SELECT "TestWrapper With Spaces.name" FROM RECORD TestRT_B'
-    row = db.execute_query(query).get_property_values(
-        ("TestWrapper With Spaces", "name"))
-    assert row == [("ReferencedRecord",)]  # FAILS
-
     query = 'SELECT "TestWrapper With Spaces".name FROM RECORD TestRT_B'
     row = db.execute_query(query).get_property_values(
         ("TestWrapper With Spaces", "name"))
-    assert row == [("ReferencedRecord",)]  # FAILS
+    assert row == [("ReferencedRecord",)]
 
 
 def test_issue_132():