Skip to content
Snippets Groups Projects

TST: Add integration test for https://gitlab.com/caosdb/caosdb-server/-/issues/136

Merged Florian Spreckelsen requested to merge f-multi-prop-update into dev
All threads resolved!

Summary

Integration test for caosdb-server#234 (closed) which had already been resolved on the server side.

Focus

New integration test in tests/test_issues_server.py

Test Environment

With an empty CaosDB run

pytest tests/test_issues_server.py::test_136

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Pipeline #23278 passed

Pipeline passed for c6a6989f on f-multi-prop-update

Merged by Daniel HornungDaniel Hornung 3 years ago (May 23, 2022 10:37am UTC)

Loading

Pipeline #23750 passed

Pipeline passed for 424b78bf on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Spreckelsen
  • Florian Spreckelsen changed the description

    changed the description

  • Florian Spreckelsen requested review from @daniel

    requested review from @daniel

  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung enabled an automatic merge when the pipeline for c6a6989f succeeds

    enabled an automatic merge when the pipeline for c6a6989f succeeds

  • Daniel Hornung mentioned in commit 424b78bf

    mentioned in commit 424b78bf

  • Please register or sign in to reply
    Loading