MAINT: comments and minor clean up
All threads resolved!
All threads resolved!
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md(or not necessary) -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen
Merge request reports
Activity
assigned to @henrik
- Resolved by Florian Spreckelsen
- Resolved by Florian Spreckelsen
marked the checklist item Reference related issues as completed
added 5 commits
-
bc09f558...cb2cf641 - 4 commits from branch
dev
- c44a06e4 - Merge branch 'dev' into f-cleanup-ci
-
bc09f558...cb2cf641 - 4 commits from branch
requested review from @florian
enabled an automatic merge when the pipeline for c44a06e4 succeeds
mentioned in commit 1394cea0
Please register or sign in to reply