Skip to content
Snippets Groups Projects

TEST: Test for server issue 217: faulty list property XML.

Merged Daniel Hornung requested to merge f-fix-description-change-w-list into dev
All threads resolved!

Summary

The server does not like to change the description if there are list valued reference properties.

This is for caosdb-server#217 (closed)

Focus

Does this reproduce the integration test problem in caosadvancedtools?

Test Environment

In directory tests, do pytest -k test_issue_217 test_issues_server.py

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass -> No
  • Reference related issues.
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Pipeline #19978 failed

Pipeline failed for 808475ed on f-fix-description-change-w-list

Approval is optional

Merged by Florian SpreckelsenFlorian Spreckelsen 3 years ago (Mar 4, 2022 9:37am UTC)

Merge details

  • Changes merged into dev with bac5b422.
  • Deleted the source branch.

Pipeline #20375 passed

Pipeline passed for bac5b422 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • added 1 commit

    • 808475ed - TST: Add Python 3.10 to tox environments

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Florian Spreckelsen marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • mentioned in commit bac5b422

  • Please register or sign in to reply
    Loading