Skip to content
Snippets Groups Projects
Verified Commit bb7cb3a8 authored by Timm Fitschen's avatar Timm Fitschen
Browse files

MAINT: replace some skips by xfails

parent dbffde90
No related branches found
No related tags found
2 merge requests!50Draft: ENH: file system: core,!8Draft: F filesystem
Pipeline #23754 failed
......@@ -674,7 +674,6 @@ def test_insert_files_in_dir_regex():
pass
@mark.skip()
def test_thumbnails():
file_ = models.File(name="TestFile",
description="Testfile Desc",
......@@ -693,6 +692,7 @@ def test_thumbnails():
"thumbnail")[-41:] == "/Thumbnails/testfiles/thumbnails_test.dat"
@mark.xfail(reason="Needs file system refactoring")
def test_auto_create_parent_dirs():
file_ = models.File(name="TestFile",
path="A/B/C/test.dat",
......@@ -773,7 +773,7 @@ def test_auto_create_parent_dirs():
assert file_1.get("url")[-26:] == "/FileSystem/A/B/C/test.dat"
@mark.skip()
@mark.xfail(reason="Needs file system refactoring")
def test_import_file():
path = get_config().get("IntegrationTests",
"test_files.test_import_files_in_dir.local") + "testfolder/"
......@@ -804,7 +804,7 @@ def test_import_file():
pass
@mark.skip()
@mark.xfail(reason="Needs file system refactoring")
def test_import_directoy():
path = get_config().get("IntegrationTests",
"test_files.test_import_files_in_dir.local") + "testfolder/"
......@@ -827,6 +827,7 @@ def test_import_directoy():
pass
@mark.xfail(reason="Needs file system refactoring")
def test_consistency_file_was_modified_2():
# this test is different from test_consistency_file_was_modified in that
# the server does actually corrupt the file.
......@@ -838,11 +839,10 @@ def test_consistency_file_was_modified_2():
path="debug/test_file_storage_consistency",
file="test.dat")
file_.insert()
checksum1 = file_.checksum
print(checksum1)
checksum1 = file_.checksum.lower()
qfile = execute_query("FIND FILE TestConsistency3", unique=True)
assert qfile.id == file_.id
assert qfile.checksum == checksum1
assert qfile.checksum.lower() == checksum1
assert file_.id is not None
assert file_.is_valid()
......@@ -866,38 +866,38 @@ def test_consistency_file_was_modified_2():
# old checksum is still stored
qfile = execute_query("FIND FILE TestConsistency3", unique=True)
assert qfile.id == file_.id
assert qfile.checksum == checksum1
assert qfile.checksum.lower() == checksum1
# download fails because the checksum changed.
with raises(db.exceptions.ConsistencyError) as exc:
file_.download(target="test.dat.tmp")
file_.download(target="test.dat.tmp", check_hash=False)
assert file_.checksum == checksum1
checksum2 = db.File.sha512("test.dat.tmp")
assert file_.checksum.lower() == checksum1
checksum2 = db.File.sha512("test.dat.tmp").lower()
file_.checksum = checksum2
assert checksum2 != checksum1
# old checksum is still stored
qfile = execute_query("FIND FILE TestConsistency3", unique=True)
assert qfile.id == file_.id
assert qfile.checksum == checksum1
assert qfile.checksum.lower() == checksum1
# here the client may validate the new file
file_.file = None
file_.update()
assert checksum2 == file_.checksum
assert checksum2 == file_.checksum.lower()
# new checksum is stored
qfile = execute_query("FIND FILE TestConsistency3", unique=True)
assert qfile.id == file_.id
assert qfile.checksum == checksum2
assert qfile.checksum.lower() == checksum2
# no ConsistencyError anymore
file_.download(target="test.dat.tmp")
assert checksum2 == file_.checksum
assert checksum2 == file_.checksum.lower()
# new checksum is still stored
qfile = execute_query("FIND FILE TestConsistency3", unique=True)
assert qfile.id == file_.id
assert qfile.checksum == checksum2
assert qfile.checksum.lower() == checksum2
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment