Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
C
CaosDB Python Integration Tests
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
caosdb
Software
CaosDB Python Integration Tests
Commits
2d9705bd
Commit
2d9705bd
authored
1 year ago
by
Henrik tom Wörden
Browse files
Options
Downloads
Patches
Plain Diff
MAINT: minimal refactor
parent
537c4c84
Branches
Branches containing commit
Tags
Tags containing commit
1 merge request
!69
TST: Add xfailing tests for the permissions for referenced entities
Pipeline
#44459
failed
1 year ago
Stage: info
Stage: setup
Stage: cert
Stage: style
Stage: test
Stage: deploy
Changes
1
Pipelines
3
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
tests/test_permissions.py
+20
-26
20 additions, 26 deletions
tests/test_permissions.py
with
20 additions
and
26 deletions
tests/test_permissions.py
+
20
−
26
View file @
2d9705bd
...
...
@@ -1200,10 +1200,12 @@ def test_deny_update_role():
@mark.xfail
(
reason
=
"
Fix insufficient permission checks of referenced entity names.
"
)
def
test_query_with_invisible_reference
():
"""
Names of references that are not visible to the test user should not be
usable as query filters.
"""
Names of references that are not visible to the test user should not be usable as query
filters.
"""
db
.
administration
.
set_server_property
(
"
QUERY_FILTER_ENTITIES_WITHOUT_RETRIEVE_PERMISSIONS
"
,
"
FALSE
"
)
rt
=
db
.
RecordType
(
name
=
"
TestRT
"
).
insert
()
rec_invisible
=
db
.
Record
(
name
=
"
TestInvisible
"
).
add_parent
(
rt
).
insert
()
...
...
@@ -1258,14 +1260,15 @@ def test_select_query_with_invisible_reference():
visible_rec
.
insert
()
# Everything is there when queried as admin
select_
results
=
db
.
execute_
query
(
select_query
=
(
f
"
SELECT name,
{
invisible_rt
.
name
}
,
{
invisible_rt
.
name
}
.name,
"
f
"
{
invisible_rt
.
name
}
.
{
prop
.
name
}
,
{
invisible_rt
.
name
}
.
{
other_rt
.
name
}
,
"
f
"
{
invisible_rt
.
name
}
.
{
other_rt
.
name
}
.name FROM
{
visible_rec
.
id
}
"
)
values
=
select_results
.
get_property_values
(
"
name
"
,
f
"
{
invisible_rt
.
name
}
"
,
(
invisible_rt
.
name
,
"
name
"
),
select_results
=
db
.
execute_query
(
select_query
)
value_args
=
[
"
name
"
,
f
"
{
invisible_rt
.
name
}
"
,
(
invisible_rt
.
name
,
"
name
"
),
(
invisible_rt
.
name
,
prop
.
name
),
(
invisible_rt
.
name
,
other_rt
.
name
),
(
invisible_rt
.
name
,
other_rt
.
name
,
"
name
"
))[
0
]
(
invisible_rt
.
name
,
other_rt
.
name
,
"
name
"
)]
values
=
select_results
.
get_property_values
(
*
value_args
)[
0
]
assert
values
[
0
]
==
visible_rec
.
name
assert
values
[
1
]
==
invisible_rec
.
id
assert
values
[
2
]
==
invisible_rec
.
name
...
...
@@ -1280,14 +1283,8 @@ def test_select_query_with_invisible_reference():
switch_to_test_user
()
select_results
=
db
.
execute_query
(
f
"
SELECT name,
{
invisible_rt
.
name
}
,
{
invisible_rt
.
name
}
.name,
"
f
"
{
invisible_rt
.
name
}
.
{
prop
.
name
}
,
{
invisible_rt
.
name
}
.
{
other_rt
.
name
}
,
"
f
"
{
invisible_rt
.
name
}
.
{
other_rt
.
name
}
.name FROM
{
visible_rec
.
id
}
"
)
values
=
select_results
.
get_property_values
(
"
name
"
,
f
"
{
invisible_rt
.
name
}
"
,
(
invisible_rt
.
name
,
"
name
"
),
(
invisible_rt
.
name
,
prop
.
name
),
(
invisible_rt
.
name
,
other_rt
.
name
),
(
invisible_rt
.
name
,
other_rt
.
name
,
"
name
"
))[
0
]
select_results
=
db
.
execute_query
(
select_query
)
values
=
select_results
.
get_property_values
(
*
value_args
)[
0
]
assert
values
[
0
]
==
visible_rec
.
name
assert
values
[
1
]
==
invisible_rec
.
id
# id is ok
assert
values
[
2
]
is
None
# name isn't
...
...
@@ -1299,22 +1296,19 @@ def test_select_query_with_invisible_reference():
switch_to_admin_user
()
select_
results
=
db
.
execute_
query
(
select_query
=
(
f
"
SELECT
{
invisible_rt
.
name
}
.
{
visible_rt
.
name
}
,
"
f
"
{
invisible_rt
.
name
}
.
{
visible_rt
.
name
}
.name FROM
{
visible_rec
.
id
}
"
)
values
=
select_results
.
get_property_values
(
(
invisible_rt
.
name
,
visible_rt
.
name
),
(
invisible_rt
.
name
,
visible_rt
.
name
,
"
name
"
))[
0
]
value_args
=
[(
invisible_rt
.
name
,
visible_rt
.
name
),
(
invisible_rt
.
name
,
visible_rt
.
name
,
"
name
"
)]
select_results
=
db
.
execute_query
(
select_query
)
values
=
select_results
.
get_property_values
(
*
value_args
)[
0
]
assert
values
[
0
]
==
referenced_visible
.
id
assert
values
[
1
]
==
referenced_visible
.
name
switch_to_test_user
()
select_results
=
db
.
execute_query
(
f
"
SELECT
{
invisible_rt
.
name
}
.
{
visible_rt
.
name
}
,
"
f
"
{
invisible_rt
.
name
}
.
{
visible_rt
.
name
}
.name FROM
{
visible_rec
.
id
}
"
)
values
=
select_results
.
get_property_values
(
(
invisible_rt
.
name
,
visible_rt
.
name
),
(
invisible_rt
.
name
,
visible_rt
.
name
,
"
name
"
))[
0
]
select_results
=
db
.
execute_query
(
select_query
)
values
=
select_results
.
get_property_values
(
*
value_args
)[
0
]
assert
values
[
0
]
is
None
assert
values
[
1
]
is
None
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment