Skip to content

F octave logging

Timm Fitschen requested to merge f-octave-logging into dev

Summary

Minor changes. Replaced a function which has been removed from cpplib, removed some std::endl in logging. Updated the pipeline (which was not working for some reason).

See Also

caosdb-cpplib!41 (merged)

Test Environment

Please try to run the integration tests (which have not been changed) and look out for our segfault bug - Maybe we can close it (and update the CHANGELOG accordingly?)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Loading