Skip to content
Snippets Groups Projects

Use "trigger" keyword for pipeline

Merged Daniel Hornung requested to merge f-trigger into dev
All threads resolved!

Summary

Use "trigger" keyword for pipeline.

Focus

Is the variable behavior correct?

Test Environment

Look at pipelines and see if they work.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues #12 (closed)
  • Up-to-date CHANGELOG.md Not necessary
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Pipeline #24272 passed

Pipeline: caosdb-octaveinttest

#24273

    Pipeline passed for 55bfa88e on f-trigger

    Approval is optional

    Merged by Henrik tom WördenHenrik tom Wörden 2 years ago (Jun 20, 2022 8:01am UTC)

    Merge details

    • Changes merged into dev with d378c486.
    • Deleted the source branch.

    Pipeline #25604 failed

    Pipeline failed for d378c486 on dev

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung requested review from @henrik

    requested review from @henrik

  • Henrik tom Wörden marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Henrik tom Wörden marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Henrik tom Wörden resolved all threads

    resolved all threads

  • Henrik tom Wörden marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Henrik tom Wörden marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Henrik tom Wörden marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

    marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

  • mentioned in commit d378c486

  • Please register or sign in to reply
    Loading