Skip to content
Snippets Groups Projects

Documentation

Merged Daniel Hornung requested to merge f-doc into dev

Summary

Minimal documentation is written now and shows up on docs.indiscale.com.

Focus

  • Is the documentation correct and complete?
  • Is the minimal example enough for users to get started?
  • Is it acceptable that the API documentation is outside sphinx?

Test Environment

  • Build: make doc_clean; make doc
  • Open the html: xdg-open build/doc/html/index.html
  • To test the pages build: download the artifact directory from the pipeline, extract it and inspect the index.html inside.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass -> integration test is allowed to fail since no corresponding repo exists there.
  • Reference related Issues: for caosdb/customers/lfpb/management#417
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

TODO

  • Add description to README_SETUP.md: how to run unit tests locally
Edited by Timm Fitschen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Daniel Hornung assigned to @timm and unassigned @daniel

    assigned to @timm and unassigned @daniel

  • Daniel Hornung changed the description

    changed the description

  • Timm Fitschen added 2 commits

    added 2 commits

    Compare with previous version

  • Timm Fitschen changed target branch from dev to f-full

    changed target branch from dev to f-full

  • Timm Fitschen
  • Timm Fitschen added 3 commits

    added 3 commits

    Compare with previous version

  • Timm Fitschen added 3 commits

    added 3 commits

    • 69d0aab4 - 1 commit from branch f-full
    • b5f7b9f0 - REVIEW: use stable DataType constructors of libcaosdb
    • 234fe134 - Merge branch 'f-full' into f-doc

    Compare with previous version

  • Timm Fitschen requested review from @timm

    requested review from @timm

  • Timm Fitschen assigned to @daniel and unassigned @timm

    assigned to @daniel and unassigned @timm

  • Timm Fitschen changed the description

    changed the description

  • Timm Fitschen added 2 commits

    added 2 commits

    • cd2221e3 - 1 commit from branch f-full
    • 5fee0f5a - Merge branch 'f-full' into f-doc

    Compare with previous version

  • Timm Fitschen
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading