Skip to content

ENH: Retrieving single entities works on the mex side.

Daniel Hornung requested to merge f-extended into dev

Summary

  • Retrieve single entity
  • Retrieve multiple entities
  • Sending queries

Focus

Please have a look at the unit tests and integration tests for usage instructions.

  • Does the entity mapping to Octave look OK?
  • Does the error handling look OK?
  • Does everything behave like ti should?

Test Environment

  • make install You can now load the package with load caosdb.
  • make test Run the unit tests
  • Start LinkAhead in the grpc branch with the demo profile.
  • make -C ../caosdb-octaveinttest test Run the integration tests.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass -> Integration tests pass locally (with default profile), Entity insertion is needed for running on the pipeline
  • Reference related Issues -> https://gitlab.indiscale.com/caosdb/customers/lfpb/management/-/issues/383
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading