Initial functionality
Summary
First implementation.
- Compiles
- Runs
- Returns errors.
Focus
- Does it build?
- Can the package be used?
- Is it possible to work with the errors?
Test Environment
- Install libcaosdb with Conan:
make conan-install
on dev branch - Install Octave package:
make install
- Configure client json configuration in some directory according to libcaosdb instructions.
- Start Octave:
octave
- Test the following:
pkg load caosdb
c = Caosdb()
c.info() # Should give the version
c2 = Caosdb(connection="doesnotexist")
c.info() # Should print an error
err = lasterror()
disp(err.identifier)
disp(err.message)
- Go into
test/
and runmake test_detailed
.make test
does not work until CMake provides a feature or workaround for https://stackoverflow.com/questions/733475/cmake-ctest-make-test-doesnt-build-tests.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related Issues: https://gitlab.indiscale.com/caosdb/customers/lfpb/management/-/issues/382 -
Up-to-date CHANGELOG.md -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there spezifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Daniel Hornung