Skip to content
Snippets Groups Projects

CI pipeline for mysql unit tests

Merged Daniel Hornung requested to merge f-mysql-test into dev

Summary

The pipeline should also run the tests with a MySQL as backend server. This MR implements this.

See also #33 (closed).

Focus

  • Does the MySQL pipeline fail at the expected point?
  • Is outsourcing pipeline code to a Makefile a reasonable step to prevent redundancy in the scripts?

Test Environment

Just watch the pipeline run.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung
  • 32 30 - test
    33 31 - deploy
    34 32
    35 # Trigger building of server image and integration tests
  • 65 39 only:
    66 40 - web
    67 41 - schedules
    42 - f-mysql-test
  • Daniel Hornung
  • 48 unittests:
    49 tags: [ docker ]
    50 stage: test
    51 script:
    52 - cp config.defaults .config
    53 - echo 'DATABASE_USER_HOST_LIST="%,"' >> .config
    54 - echo "MYSQL_USER_PASSWORD=$MYSQL_ROOT_PASSWORD" >> .config
    55 - echo "MYSQL_HOST=mariadb" >> .config
    56 - sleep 10
    57 - make install
    58 - ./utils/make_db restore_db tests/example.dump.sql
    59 - ./tests/test_utils.sh
    33 ######## Setup ########
    60 34
    61 35 # Build a docker image in which tests for this repository can run
    62 36 build-testenv:
    • By the way, we only want to test if different backends work, the intent of this MR is not to find out if different SQL command line clients can run the tests. So one single testenv image with the MariaDB client should be sufficient.

    • Please register or sign in to reply
  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Daniel Hornung added 1 commit

    added 1 commit

    • e43dc4cb - MAINT: Removed WIP branch from CI

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    • 286db9e7 - REVEIW: removed accidential changes in a comment

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    • f7e6c359 - REVIEW: add unit tests agains 5.7

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    • 659d5d03 - PIPELINE: fix syntax error in .gitlab-ci.yml

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    • 0264728c - WIP: unit tests for mysql 5.7

    Compare with previous version

  • Timm Fitschen marked this merge request as draft from 0264728c

    marked this merge request as draft from 0264728c

  • Timm Fitschen added 1 commit

    added 1 commit

    • 6a3b7ed8 - PIPELINE: remove test/test_0_autotap.sql for mysql unit test

    Compare with previous version

  • Timm Fitschen added 1 commit

    added 1 commit

    • 72b40245 - DOC: add troubleshooting sec to README for unit tests

    Compare with previous version

  • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Timm Fitschen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Timm Fitschen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading