Skip to content
Snippets Groups Projects

F cleanup rules

Merged Timm Fitschen requested to merge f-cleanup-rules into dev
All threads resolved!

Summary

After caosdb-server#146 (closed) the rules table and the getRules procedure are obsolete. This MR removes them.

Check List for the Author

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Timm Fitschen
  • Timm Fitschen requested review from @daniel

    requested review from @daniel

  • Daniel Hornung resolved all threads

    resolved all threads

  • What about https://gitlab.indiscale.com/caosdb/src/caosdb-mysqlbackend/-/blob/4de568edeca3a31750b99a539828706eaff1ff2e/db_2_0.sql#L264 ? Is the idea that the "old" db should be created anyways, but the table be deleted later, so that all patches apply cleanly?

    The same question holds for tests/example.dump.sql

    Everything else looks good to me.

    Edited by Daniel Hornung
  • Daniel Hornung added 1 commit

    added 1 commit

    • bfa5f764 - DOC: Added documentation, fixed copyright notice.

    Compare with previous version

  • Daniel Hornung mentioned in commit cc826d33

    mentioned in commit cc826d33

  • Please register or sign in to reply
    Loading