Skip to content
Snippets Groups Projects

REL: prepare release 7.0.1

Merged Timm Fitschen requested to merge release-7.0.1 into main
All threads resolved!

Summary

  • Add sanity checks to assure that all the correct tables (and only those) are present after install/upgrade
  • Remove fail-fast-n-hard sanity check which only checks the passwords table.

Related issue: #51 (closed)

Test Environment

See how the sanity check failed here: cc932e83 and passed here: 2ae46a9c

Test with upcomming linkahead release and the demo profile.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Pipeline #43123 passed

Pipeline: LinkAhead

#43124

    Pipeline passed for 2ae46a9c on release-7.0.1

    Approval is optional

    Merged by Henrik tom WördenHenrik tom Wörden 1 year ago (Nov 2, 2023 10:48am UTC)

    Merge details

    Pipeline #43157 passed

    Pipeline: LinkAhead

    #43159

      Pipeline passed for 9565bd4f on main

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Timm Fitschen
    • Timm Fitschen marked the checklist item Annotations in code (Gitlab comments) as completed

      marked the checklist item Annotations in code (Gitlab comments) as completed

    • Timm Fitschen changed the description

      changed the description

    • Timm Fitschen marked the checklist item All automated tests pass as completed

      marked the checklist item All automated tests pass as completed

    • Timm Fitschen
    • Henrik tom Wörden resolved all threads

      resolved all threads

    • Henrik tom Wörden marked the checklist item I understand the intent of this MR as completed

      marked the checklist item I understand the intent of this MR as completed

    • Henrik tom Wörden marked the checklist item All automated tests pass as completed

      marked the checklist item All automated tests pass as completed

    • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

      marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    • Henrik tom Wörden marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

      marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    • Henrik tom Wörden marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

      marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    • Henrik tom Wörden marked the checklist item In-code documentation and comments are up-to-date. as completed

      marked the checklist item In-code documentation and comments are up-to-date. as completed

    • Henrik tom Wörden marked the checklist item Check: Are there specifications? Are they satisfied? as completed

      marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    • mentioned in commit 9565bd4f

    • Please register or sign in to reply
      Loading