External String IDs
-
Review changes -
-
Download -
Patches
-
Plain diff
All threads resolved!
All threads resolved!
Summary
Back-end implementation for caosdb-server!78 (merged)
Focus
- Externally used entities ids and internal ids are mapped in the new entity_ids table.
- Internal_ids are beeing generatated by the auto_increment feature of the entities table.
- Most of the changes have the pattern: Replace any occurrence of
SELECT ... FROM entities WHERE id = ?
withSELECT ... FROM entities JOIN entity_ids ON entities.id = entity_ids.internal_id WHERE entity_ids.id = ?
- Some of the procedure now take a
EntityID VARCHAR(255)
instead ofÈntityID UNSIGNED INT
. These belong to the public api which is used by the server. The remaining procedure where the parameter is namesInternalEntityID UNSIGNED INT
now, are part of the implementation. - There should be only one case where internal ids are being leaked into the public api, that is as replacement ids. In that case the internal ids are then being replaced by the server during the transformation from the flat property internal representation to the deep public one.
- Some of the new procedures are just old code from the server, copied and refactored.
- Also, some unrelated refactoring and clean-up was done.
Test Environment
No manual testing.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Daniel Hornung
Merge request reports
Compare and
- version 18fce61eca
- version 1707c540b1
- version 1628ffe80a
- version 150e78ed18
- version 1409c88b76
- version 13918af4df
- version 12d8a2e7ae
- version 1150acb681
- version 10a4b158c4
- version 9f9ecefef
- version 8dd442f94
- version 731bd65fa
- version 66a3883be
- version 5fd2317dd
- version 40820b276
- version 35226c269
- version 2450b0122
- version 12280def3
- dev (base)
- latest version58e97cb023 commits,
- version 18fce61eca22 commits,
- version 1707c540b120 commits,
- version 1628ffe80a19 commits,
- version 150e78ed1817 commits,
- version 1409c88b7616 commits,
- version 13918af4df15 commits,
- version 12d8a2e7ae14 commits,
- version 1150acb68113 commits,
- version 10a4b158c411 commits,
- version 9f9ecefef10 commits,
- version 8dd442f949 commits,
- version 731bd65fa8 commits,
- version 66a3883be7 commits,
- version 5fd2317dd6 commits,
- version 40820b2765 commits,
- version 35226c2694 commits,
- version 2450b01223 commits,
- version 12280def32 commits,
Compare changes
- Side-by-side
- Inline
Files
40Loading