DRAFT: ENH: Include libcaosdb and a minimal wrapper
Summary
Insert a meaningful description for this merge request here. What is the
new/changed behavior? Which bug has been fixed? Are there related Issues?Focus
Point the reviewer to the core of the code change. Where should they start
reading? What should they focus on (e.g. security, performance,
maintainability, user-friendliness, compliance with the specs, finding more
corner cases, concrete questions)?Test Environment
How to set up a test environment for manual testing?Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related Issues -
Up-to-date CHANGELOG.md -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there spezifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
Activity
added 1 commit
- 3900296b - DRAFT: Add dummy wrapper to test including libcaosdb
added 1 commit
- b1687958 - ENH: Replace dummy function by libcaosdb version retrieval
1 4 module CaosDB 2 5 3 export dummy_func 6 using CxxWrap 7 8 "Generic super type of CaosDB exceptions" 9 abstract type AbstractCaosDBException <: Exception end 10 11 "An error occurred while trying to authenticate" 12 abstract type AbstractAuthenticationError <: AbstractCaosDBException end 13 14 "Connection couldn't be established" 15 abstract type AbstractConnectionError <: AbstractCaosDBException end 16 17 # Adapt this path if you haven't compiled jlcaosdb to `caosdb-julialib/build` 18 @wrapmodule(joinpath(@__DIR__, "../jlcaosdb/build/lib/libjlcaosdb")) -
This is still quite ugly. As soon as we can export a JLL of jlcaosdb using BinaryBuilder.jl, we can provide the JLL instead of a path here. The users will have to install as a Julia dependency, of course. Creating the JLL is part of https://gitlab.indiscale.com/caosdb/customers/lfpb/management/-/issues/402, so I suggest we leave it like this for now.
added 1 commit
- 1d0944e3 - DRAFT: Add broken PlainPasswordAuthenticator
added 1 commit
- fa06b4c1 - WIP: Remove non-working wrappers and let it rest for now