Skip to content
Snippets Groups Projects

ENH: Add tests for minimal functionality

Merged ENH: Add tests for minimal functionality
f-minimal into dev
1 unresolved thread
Merged Florian Spreckelsen requested to merge f-minimal into dev
1 unresolved thread

Summary

Integration tests for https://gitlab.indiscale.com/caosdb/customers/lfpb/management/-/issues/381 and caosdb-julialib!4 (merged). Review is done in https://gitlab.com/caosdb/caosdb-juliainttest/-/merge_requests/1

Insert a meaningful description for this merge request here.  What is the
new/changed behavior? Which bug has been fixed? Are there related Issues?

Focus

Point the reviewer to the core of the code change. Where should they start
reading? What should they focus on (e.g. security, performance,
maintainability, user-friendliness, compliance with the specs, finding more
corner cases, concrete questions)?

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
test/runtests.jl
55 55 end
56 56 end
57 57
58 # test whether connection can be established without an error
59 @test CaosDB.Connection.connect() != nothing
58 @testset "Test CaosDB" begin
59
60 @testset "Test connection" begin
61 # test whether connection can be established without an error
62 @test CaosDB.Connection.connect() != nothing
63 @test CaosDB.Connection.connect("julialib-integrationtest") != nothing
  • Florian Spreckelsen
    Florian Spreckelsen @florian ·
    Author Owner

    We could in principle add a lot more tests here with different configs, also errors with broken configs. However, this is already done in the cppinttests, so I think it's sufficient to test that Julia can establish a connection with a correct config file.

  • Please register or sign in to reply
  • Florian Spreckelsen changed the description

    changed the description

  • Florian Spreckelsen added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Spreckelsen marked this merge request as ready

    marked this merge request as ready

  • Florian Spreckelsen mentioned in commit 6b9a7039

    mentioned in commit 6b9a7039

  • Florian Spreckelsen merged

    merged

    • Please register or sign in to reply