Skip to content
Snippets Groups Projects

F review

Merged
Florian Spreckelsenrequested to merge
f-review into main
All threads resolved!

Summary

Review of https://gitlab.indiscale.com/caosdb/internal/all/-/issues/994. Mainly adds TODOS to the README_SETUP.md

Focus

Did I forget something when adding the TODOS?

Test Environment

Just read the README

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Spreckelsen
  • requested review from @henrik

  • added 1 commit

    • 7258625e - DOC: added docs on how to add further configuration

    Compare with previous version

  • added 1 commit

    • 04d3a41b - MAINT: add changelog, license and release guide

    Compare with previous version

  • Henrik tom Wörden resolved all threads

    resolved all threads

  • mentioned in commit 6bb98a5c

  • Please register or sign in to reply
    Loading