Draft: F converters else clause

Summary

See: #81 (moved)

Focus

Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caoscrawler/crawl.py

@@ -1141,6 +1141,7 @@ ____________________\n""".format(i + 1, len(pending_changes)) + str(el[3]))
         # This path_found variable stores wether the path given by restricted_path was found in the
         # data tree
         path_found = False
+        # at_least_one_match = False
         if restricted_path is not None and len(restricted_path) == 0:
             restricted_path = None
 
@@ -1152,6 +1153,7 @@ ____________________\n""".format(i + 1, len(pending_changes)) + str(el[3]))
                 if (converter.typecheck(element) and (
                         restricted_path is None or element.name == restricted_path[0])
                         and converter.match(element) is not None):
+                    # at_least_one_match = True
                     path_found = True
                     generalStore_copy = generalStore.create_scoped_copy()
                     recordStore_copy = recordStore.create_scoped_copy()
@@ -1195,10 +1197,14 @@ ____________________\n""".format(i + 1, len(pending_changes)) + str(el[3]))
                                 structure_elements_path + [element.get_name()],
                                 converters_path + [converter.name],
                                 restricted_path[1:] if restricted_path is not None else None)
+                
 
         if restricted_path and not path_found:
             raise RuntimeError("A 'restricted_path' argument was given that is not contained in "
                                "the data tree")
+        # if not at_least_one_match:
+        #     run_ELSE_converter()
+            
         # if the crawler is running out of scope, copy all records in
         # the recordStore, that were created in this scope
         # to the general update container.