Release 0.3

Summary

For #73 (closed).

Insert a meaningful description for this merge request here: What is the new/changed behavior? Which bug has been fixed? Are there related issues?

Focus

Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?

Test Environment

How to set up a test environment for manual testing?

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

integrationtests/basic_example/test_basic.py

@@ -33,6 +33,7 @@ import argparse
 import sys
 from argparse import RawTextHelpFormatter
 from caoscrawler import Crawler, SecurityMode
+from caoscrawler.identifiable import Identifiable
 import caosdb as db
 from caoscrawler.identifiable_adapters import CaosDBIdentifiableAdapter
 import pytest
@@ -106,6 +107,15 @@ def crawler_extended(ident):
     return cr
 
 
+def test_ambigious_lookup(clear_database, usemodel, crawler, ident):
+    ins, ups = crawler.synchronize()
+
+    proj = db.execute_query("FIND Project WITH identifier='SpeedOfLight'", unique=True)
+    with pytest.raises(RuntimeError, match=".*unambigiously.*"):
+        print(crawler.identifiableAdapter.retrieve_identified_record_for_identifiable(
+            Identifiable(properties={'project': proj.id})))
+
+
 def test_single_insertion(clear_database, usemodel, crawler, ident):
     ins, ups = crawler.synchronize()
 
@@ -114,14 +124,15 @@ def test_single_insertion(clear_database, usemodel, crawler, ident):
     for i in reversed(range(len(res))):
         if res[i].parents[0].name == "PyTestInfo":
             del res[i]
-    filename = rfp("..", "..", "unittests", "records.xml")
-    with open(filename, "w") as f:
-        xml = res.to_xml()
-        # Remove noscript and transaction benchmark:
-        for tag in ("noscript", "TransactionBenchmark"):
-            if xml.find(tag) is not None:
-                xml.remove(xml.find(tag))
-        f.write(db.common.utils.xml2str(xml))
+    # uncomment this to recreate the `records.xml` file
+    # filename = rfp("..", "..", "unittests", "records.xml")
+    # with open(filename, "w") as f:
+    #    xml = res.to_xml()
+    #    # Remove noscript and transaction benchmark:
+    #    for tag in ("noscript", "TransactionBenchmark"):
+    #        if xml.find(tag) is not None:
+    #            xml.remove(xml.find(tag))
+    #    f.write(db.common.utils.xml2str(xml))
 
     assert len(ins) == 18
     assert len(ups) == 0