Skip to content
Snippets Groups Projects

ENH: introduce JSON converter

Merged Henrik tom Wörden requested to merge f-json-converter into dev

Summary

For https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/46. Create a converter that reads a JSON file.

Focus

Some new converters and a lot of fixes on the way.

Test Environment

Some new unit tests, use ZMT example for manual testing.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • [ ] All automated tests pass
  • Reference related issues
  • [ ] Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • [ ] All automated tests pass
  • [ ] Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Schlemmer approved this merge request

    approved this merge request

  • added 5 commits

    Compare with previous version

  • added 1 commit

    • d74340b7 - MAINT: remove staticmethod definitions, move test file

    Compare with previous version

  • added 1 commit

    • cc10f126 - MAINT: inherit jsonconverter from dictconverter

    Compare with previous version

  • added 1 commit

    • f283b4b9 - MAINT: introduce more dict elements

    Compare with previous version

  • added 1 commit

    • 0090ef97 - MAINT: let dict elements inherit from DictElement

    Compare with previous version

  • added 1 commit

    • ed4f079f - ENH: add json schema validation

    Compare with previous version

  • added 1 commit

    • 44e319ec - MAINT: allow using schemas defined in files

    Compare with previous version

  • added 2 commits

    • d3097dda - ENH: add file struct
    • e01b7b9e - ENH: add fileconverter and fix json load

    Compare with previous version

  • Florian Spreckelsen changed the description

    changed the description

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading