Skip to content

Add debugging for matching of converters

Henrik tom Wörden requested to merge f-debug-match into dev

Summary

implements https://gitlab.com/caosdb/caosdb-crawler/-/issues/53

Focus

I removed the function that was supposed to be overwritten by subclasses in favor of an argument for the decorator that controls the behavior of the debugging. I think this is the version with less boiler plate code.

Test Environment

Try it out yourself ;-)

Unittests cover it only vaguely, but I think it is sufficient for a debugging feature.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues #70 (closed)
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading