Skip to content

ListConverter treats StructureElements

Henrik tom Wörden requested to merge f-changes-for-dicom into dev

Summary

This allows a ListConverter to treat elements that were created by another Converter. For example a specialized DictElementConverter could return StructureElements in two lists instead of one and you might want to use a cfood definition like:

                type: SpecialConverter
                  match: .*
                  subtree:
                    series_list:
                      type: DictListElement
                      match_name: (?P<series_no>.*)

Focus

There is also a change that enhances debugging output.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Loading