Skip to content

F upate overwrite

Florian Spreckelsen requested to merge f-upate-overwrite into dev

Summary

Confirmation for #47 (closed) (https://gitlab.com/caosdb/caosdb-crawler/-/issues/23). Adds an xfailing test that should verify that crawler updates don't overwrite existing properties.

Focus

New integration test.

Test Environment

Start LinkAhead>=0.9 with the integrationtests/test-profile/profile.yml and run

cd integrationtests
pytest -vvv test_issues.py

and verify that it xfails correctly (you can also remove the xfail and check that name and prop_a are overwritten wrongly).

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports