FIX: use identifiable instead of record

The crawler has internal checks in order to decide whether a Record can be checked for existence with the server. For this, all identifying properties need to be existent and all references of those need to be resolved or also records that can be checked themselves (so that they can be checked first).

Previously, the crawler required that ALL reference Properties can be checked or are resolved in order decide that the Record at hand can be checked.

Example: RT A with properties b and c

The registered identifiable is A with b

Record A
  b = 1234

can be checked (but the old code assumed it cannot.)

Record A
  c = 2344

cannot be checked since the identifying prop is missing.

Please consider !56 (merged)

src/newcrawler/identifiable_adapters.py

@@ -121,10 +121,6 @@ class IdentifiableAdapter(object):
         """
         pass
 
-    @abstractmethod
-    def resolve_reference(self, record: db.Record):
-        pass
-
     def get_identifiable(self, record: db.Record):
         """
         retrieve the registred identifiable and fill the property values to create an
@@ -223,8 +219,9 @@ class LocalStorageIdentifiableAdapter(IdentifiableAdapter):
         with open(filename, "r") as f:
             self._records = db.Container().from_xml(f.read())
 
-    # TODO: move to super class?
-    def is_identifiable_for_record(self, registered_identifiable: db.RecordType, record: db.Record):
+    def is_identifiable_for_record(self,
+                                   registered_identifiable: db.RecordType,
+                                   record: db.Record):
         """
         Check whether this registered_identifiable is an identifiable for the record.
 
@@ -301,22 +298,6 @@ class LocalStorageIdentifiableAdapter(IdentifiableAdapter):
             return None
         return candidates[0]
 
-    def resolve_reference(self, value: db.Record):
-        if self.get_registered_identifiable(value) is None:
-            raise NotImplementedError("Non-identifiable references cannot"
-                                      " be used as properties in identifiables.")
-            # TODO: just resolve the entity
-
-        value_identifiable = self.retrieve_identified_record(value)
-        if value_identifiable is None:
-            raise RuntimeError("The identifiable which is used as property"
-                               " here has to be inserted first.")
-
-        if value_identifiable.id is None:
-            raise RuntimeError("The entity has not been assigned an ID.")
-
-        return value_identifiable.id
-
 
 class CaosDBIdentifiableAdapter(IdentifiableAdapter):
     """