Skip to content

F fix two doc validation

Florian Spreckelsen requested to merge f-fix-two-doc-validation into dev

Summary

Fixes the missing validation of custom converters defined in the separate metadata.

Focus

Mainly just adds the Converters section from the metadata document to the schema. Also refactors Crawler.load_definition a little for better unit testing.

Test Environment

New unit test should be sufficient but feel free to try with any other two-document cfood definition.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Loading