TST: Make NamedTemporaryFiles Windows-compatible
Summary
Fixes #194 (closed). We mainly add meaningful treatment of NA values to converters.match_name_and_value
where they are now interpreted as empty strings. This fixes the issue in tables but also in generic structure elements like TextElement
(see new unit test).
Focus
Can you imagine unintended side effects of the new behavior?
Test Environment
New unit test should be sufficient.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
Activity
assigned to @florian
- Resolved by Daniel Hornung
- Resolved by Daniel Hornung
requested review from @daniel
added 1 commit
- 22b53f7a - STY, DOC: A few small changes to documentation and regression test.