Re-enable rocrate dependency
Summary
See: #181 (closed)
Test Environment
- I exported a file from kadi4mat (e.g. https://demo-kadi4mat.iam.kit.edu/).
- I created a venv and installed the pypi rocrate package.
- I verified that the file can be loaded using
rocrate
. In order to do that unzip the eln file, e.g.:unzip file.eln
- Run the following code using the venv:
from rocrate.rocrate import ROCrate rc = ROCrate("file/")
If it was still broken we would get the following error:
ValueError: no @id in {'@type': 'TextObject', 'encodingFormat': 'text/plain', 'text': 'JSON export of file.'}
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
Activity
requested review from @florian
assigned to @salexan
I needed to adapt the tests, because not all files in the ELN repo have been updated already to reflect the corrected flat rocrate structure.
However, the kadi4mat export is already repaired, so I added some xfails and removed the PASTA.eln example. This one can be activated as soon as the example has been updated in the repo.
mentioned in issue #181 (closed)
added 1 commit
- 66595e57 - TST: deactivated zip file test for outdated eln and added simple zip test
- Resolved by Florian Spreckelsen
- Resolved by Alexander Schlemmer
- Resolved by Alexander Schlemmer
mentioned in merge request !215 (merged)