Skip to content
Snippets Groups Projects

Re-enable rocrate dependency

Merged Alexander Schlemmer requested to merge f-reenable-rocrate-dep into dev

Summary

See: #181 (closed)

Test Environment

  • I exported a file from kadi4mat (e.g. https://demo-kadi4mat.iam.kit.edu/).
  • I created a venv and installed the pypi rocrate package.
  • I verified that the file can be loaded using rocrate. In order to do that unzip the eln file, e.g.: unzip file.eln
  • Run the following code using the venv:
    from rocrate.rocrate import ROCrate
    rc = ROCrate("file/")

If it was still broken we would get the following error:

ValueError: no @id in {'@type': 'TextObject', 'encodingFormat': 'text/plain', 'text': 'JSON export of file.'}

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Pipeline #60850 passed

Pipeline passed for 088292b8 on f-reenable-rocrate-dep

Merged by Alexander SchlemmerAlexander Schlemmer 3 weeks ago (Feb 14, 2025 9:50am UTC)

Loading

Pipeline #61552 passed

Pipeline passed for ef85f13f on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Schlemmer marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Alexander Schlemmer marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Alexander Schlemmer marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Alexander Schlemmer marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Alexander Schlemmer marked the checklist item Up-to-date JSON schema (or not necessary) as completed

    marked the checklist item Up-to-date JSON schema (or not necessary) as completed

  • Alexander Schlemmer marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Alexander Schlemmer mentioned in merge request !215 (merged)

    mentioned in merge request !215 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading